Skip to content

feat: enable SQLGlot compiler as default #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chelsea-lin wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Draft

feat: enable SQLGlot compiler as default #2248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigframes/core/compile/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from bigframes.core.compile.api import test_only_ibis_inferred_schema
from bigframes.core.compile.configs import CompileRequest, CompileResult
from bigframes.core.compile.ibis_compiler.ibis_compiler import compile_sql
from bigframes.core.compile.sqlglot.compiler import compile_sql

__all__ = [
"test_only_ibis_inferred_schema",
Expand Down
6 changes: 4 additions & 2 deletions bigframes/session/direct_gbq_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
import google.cloud.bigquery.table as bq_table

from bigframes.core import compile, nodes
from bigframes.core.compile import sqlglot
from bigframes.core.compile.ibis_compiler.ibis_compiler import (
compile_sql as compile_sql_ibis,
)
import bigframes.core.events
from bigframes.session import executor, semi_executor
import bigframes.session._io.bigquery as bq_io
Expand All @@ -40,7 +42,7 @@ def __init__(
):
self.bqclient = bqclient
self._compile_fn = (
compile.compile_sql if compiler == "ibis" else sqlglot.compile_sql
compile_sql_ibis if compiler == "ibis" else compile.compile_sql
)
self._publisher = publisher

Expand Down