feat: Display custom multi-index in anywidget mode #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: l
shuoweil
changed the title
shuoweil
force-pushed
the
shuowei-anywidget-index-testcase
branch
from
441bb94 to
33fd6e3
Compare
shuoweil
changed the title
tswast
reviewed
Nov 12, 2025
bigframes/display/html.py
Outdated
Comment on lines
32
to
80
| def _calculate_rowspans(dataframe: pd.DataFrame) -> list[list[int]]: | ||
| """Calculates the rowspan for each cell in a MultiIndex DataFrame. | ||
| Args: | ||
| dataframe (pd.DataFrame): | ||
| The DataFrame for which to calculate index rowspans. | ||
| Returns: | ||
| list[list[int]]: | ||
| A list of lists, where each inner list corresponds to an index level | ||
| and contains the rowspan for each row at that level. A value of 0 | ||
| indicates that the cell should not be rendered (it's covered by a | ||
| previous rowspan). | ||
| """ | ||
| if not isinstance(dataframe.index, pd.MultiIndex): | ||
| # If not a MultiIndex, no rowspans are needed for the index itself. | ||
| # Return a structure that indicates each index cell should be rendered once. | ||
| return [[1] * len(dataframe.index)] if dataframe.index.nlevels > 0 else [] | ||
|
|
||
| rowspans: list[list[int]] = [] | ||
| for level_idx in range(dataframe.index.nlevels): | ||
| current_level_spans: list[int] = [] | ||
| current_value = None | ||
| current_span = 0 | ||
|
|
||
| for i in range(len(dataframe.index)): | ||
| value = dataframe.index.get_level_values(level_idx)[i] | ||
|
|
||
| if value == current_value: | ||
| current_span += 1 | ||
| current_level_spans.append(0) # Mark as covered by previous rowspan | ||
| else: | ||
| # If new value, finalize previous span and start a new one | ||
| if current_span > 0: | ||
| # Update the rowspan for the start of the previous span | ||
| current_level_spans[i - current_span] = current_span | ||
| current_value = value | ||
| current_span = 1 | ||
| current_level_spans.append(0) # Placeholder, will be updated later | ||
|
|
||
| # Finalize the last span | ||
| if current_span > 0: | ||
| current_level_spans[len(dataframe.index) - current_span] = current_span | ||
|
|
||
| rowspans.append(current_level_spans) | ||
|
|
||
| return rowspans | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
While this makes for a somewhat cleaner view, I think we'd be better off not implementing rowpans. For example sorting by the various index columns is less intuitive if the index isn't rendered the same as other columns.
bigframes/display/html.py
Outdated
| table_html.append(' <tr style="text-align: left;">') | ||
|
|
||
| # Add index headers | ||
| for name in dataframe.index.names: |
Collaborator
There was a problem hiding this comment.
Let's try to actually refer to the original BigFrames DataFrame when deciding which index columns to render or not. In particular, we should not render the index if the BigFrame DataFrame has a NULL index.
This reverts commit 0353dc5.
…572fcdbbb01d7cda1929cb
…mode.ipynb" This reverts commit 5919552aa4158bdf4c3de12b12270f75314b8418.
product-auto-label
bot
added
size: xl
shuoweil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements related to the
anywidgetdisplay mode. For displaying multi-index DataFrames in anywidget mode, it will be rendered with a nested "semi-exploding" view, similar to BigQuery web UI.Added Index and Multi-Index DataFrame Example to Notebook:
notebooks/dataframes/anywidget_mode.ipynbnotebook now includes a new section demonstrating how to display a DataFrame with a MultiIndex using real data from the PyPI public dataset. This enhances the notebook's examples for complex data structures.Added Index and Multi-Index System Tests:
See an example here: screen/6nyCvGjzpRwM2nW
Fixes #<459515995> 🦕