chore: librarian update image pull request: 20251216T180352Z

[parthea]

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:eec191fc4904c204cd717c79812cd66997b5559776483ee223f69c8f43e99224

[gemini-code-assist]

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a routine update of the python-librarian-generator image, which has resulted in the regeneration of many client library files. Key changes include the addition of 'do not edit' headers to generated files, a refactoring of mTLS client certificate handling logic for improved maintainability, and updates to Python version support and testing configurations to align with current development practices.

Highlights

• Librarian Image Update: The python-librarian-generator image has been updated to a new SHA256 hash, triggering widespread regeneration of client library files.
• Generated File Headers: A new header comment has been added to numerous generated files, explicitly stating that they should not be edited outside of .librarian/generator-input and that this directory is their source of truth.
• mTLS Client Certificate Handling Refinement: The client services (ConfigServiceV2Client, LoggingServiceV2Client, MetricsServiceV2Client) now include a new static method _use_client_cert_effective to centralize the logic for determining mTLS client certificate usage, improving clarity and reducing redundancy. This also involved updating related environment variable checks and test cases.
• Python Version Support and Testing Updates: The noxfile.py and setup.py configurations have been adjusted. DEFAULT_PYTHON_VERSION is now '3.10', Python 3.14 has been removed from unit test versions, and system tests now target Python 3.12. The prerelease_deps session now targets Python 3.13, and the logic for skipping C++ protobuf implementation for newer Python versions has been refined. Python 3.13 and 3.14 are also removed from setup.py classifiers.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be an automated update from the librarian tool, primarily focused on updating the generator image and refactoring mTLS client certificate handling. The changes introduce a new _use_client_cert_effective helper method to centralize the logic for determining whether to use a client certificate, which is a good improvement. The test suite has been updated accordingly with more comprehensive tests for this new logic. However, I've noticed an inconsistency in the declared Python version support between setup.py and noxfile.py which should be addressed.

I am having trouble creating individual review comments. Click here to see my feedback.

setup.py (88-89)

There seems to be an inconsistency regarding Python 3.13 support. This change removes Python 3.13 from the classifiers in setup.py, suggesting it's no longer supported. However, noxfile.py still includes "3.13" in the UNIT_TEST_PYTHON_VERSIONS list, and the prerelease_deps session is now pinned to run on Python 3.13.

Please ensure the supported versions are consistent across setup.py and the test configurations in noxfile.py. If Python 3.13 is still supported, it should be added back here.