chore: librarian update image pull request: 20251216T194007Z

[parthea]

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209

Generation failed for

• google-cloud-logging

[parthea]

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

[gemini-code-assist]

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily updates the librarian image, a tool responsible for code generation, and adjusts the Python development environment configuration. Key changes include extending Python version support in noxfile.py and setup.py to include Python 3.14, and updating the Docker image for the Python librarian generator. A significant part of this PR involves the removal of numerous generated client files and documentation related to google-cloud-logging, suggesting a shift in how this specific library is managed or generated by the librarian tool.

Highlights

• Librarian Image Update: The core librarian image used for Python client library generation has been updated to a newer version, reflecting the latest tooling and configurations.
• Python 3.14 Support: Python 3.14 has been integrated into the development environment, including updates to supported unit test versions and setting it as the default Python version for various development tasks in noxfile.py and setup.py.
• google-cloud-logging Code Removal: All generated client code, associated metadata, and documentation for the google-cloud-logging library have been removed, indicating a significant change in its generation or management strategy by the librarian tool.
• Development Environment Refinements: Updates to noxfile.py include more granular unit test sessions, the addition of setuptools for lint_setup_py, and improved logic for handling protobuf C++ implementations across different Python versions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be the result of a failed generator run, as indicated by the PR description: 'Generation failed for google-cloud-logging'. A very large number of source files have been deleted, which would break the library. This is a critical issue. Please investigate the generator failure and revert the file deletions before this PR can be considered for merging.

Aside from the deleted files, the modifications to the generator input files seem reasonable, including updates to Python versions and dependencies. I have one suggestion in .librarian/generator-input/noxfile.py to improve maintainability.

[gemini-code-assist]

For better maintainability and to avoid manually updating this list every time UNIT_TEST_PYTHON_VERSIONS changes, you can generate this list of sessions programmatically. This will make the configuration more robust and less error-prone.

Suggested change

	"unit-3.9",
	"unit-3.10",
	"unit-3.11",
	"unit-3.12",
	"unit-3.13",
	"unit-3.14",
	*[f"unit-{version}" for version in UNIT_TEST_PYTHON_VERSIONS],