Skip to content

fix(gmail): parse message headers case-insensitively#815

Open
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:rescue/gmail-header-case-insensitive
Open

fix(gmail): parse message headers case-insensitively#815
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:rescue/gmail-header-case-insensitive

Conversation

@Lubrsy706
Copy link
Copy Markdown

Summary

  • normalize Gmail header names before matching standard fields
  • handle mixed/lower/upper-case variants for From, Reply-To, To, Cc, Subject, Date, Message-ID, and References
  • add a regression test plus a patch changeset

Resubmits the focused Gmail header robustness fix from #798 after the stale bot closed that PR for inactivity.

Testing

  • cargo test -p google-workspace-cli test_parse_original_message_headers_are_case_insensitive
  • git diff origin/main..HEAD --check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: 9b8a3ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of Gmail message header parsing by making it case-insensitive. By normalizing header names before matching, the system can now reliably handle inconsistent casing in email metadata, preventing potential parsing failures. This change includes a comprehensive regression test to ensure future stability.

Highlights

  • Case-Insensitive Header Parsing: Updated the Gmail message header parsing logic to normalize header names to lowercase, ensuring compatibility with various casing formats for standard fields like From, To, and Subject.
  • Regression Testing: Added a new test case, test_parse_original_message_headers_are_case_insensitive, to verify that headers with mixed-case names are correctly parsed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label May 19, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gmail message header parsing logic to be case-insensitive by converting header names to lowercase before matching. It also includes a new test case to verify that headers with mixed casing are correctly processed and a changeset file documenting the patch. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants