fix(gmail): improve attachment data handling#816
Conversation
🦋 Changeset detectedLatest commit: 761a113 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issues with Gmail attachment data handling by introducing automatic padding for base64url encoded responses. By normalizing these responses at the point of retrieval, the CLI ensures that downstream tools can consume the data without manual intervention. Additionally, the documentation and recipes have been updated to reflect the recommended workflow for downloading and decoding these attachments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves Gmail attachment handling by ensuring base64-encoded attachment data is correctly padded in JSON responses. It introduces a normalize_json_response function in the executor to handle specific method requirements, specifically adding '=' padding for the gmail.users.messages.attachments.get endpoint. The documentation and recipes were also updated to include a decode-and-upload flow using jq and python3 for base64url decoding, and unit tests were added to verify the padding logic. I have no feedback to provide.
Summary
dataresponses fromusers.messages.attachments.getso standard base64url decoders can consume them directlygws drive +uploadfile argument formThis combines and refreshes the attachment-related fixes from #795 and #797 after those PRs were closed by the stale bot.
Testing