This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Seperate react components into single files#728
Open
Conversation
azerella
added
architecture
added 22 commits
April 12, 2019 11:48
azerella
force-pushed
the
feature/seperate-react-files
branch
from
ee283f1 to
b4086e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our react components are all bundled into the single file, this PR separates each component into a seperate file.
The seperate files are concatenated together in the
lib/react/react.jsand then bundled like normal.NOTES:
formcomponent requires other component libraries when runningwebpack, during the build process, when said libs haven't built yet, an error occurs. To mitigate this we need to removebuild:reactfrom the mainbuildscript inform. This is issue is also referenced in Update AUlabel selector to addmargin-topfor allHTMLInputElement#730