Optimize GFQL GPU hot paths and RAPIDS benchmarks#972
Open
Optimize GFQL GPU hot paths and RAPIDS benchmarks#972
Conversation
lmeyerov
commented
Mar 30, 2026
graphistry/compute/hop.py
Outdated
| return cast(Any, df)[[col]] | ||
|
|
||
| def _column_values(df: Any, col: str) -> Any: | ||
| return cast(Any, df)[col] |
8ca42fc to
bb6bd69
Compare
bb6bd69 to
cf94b0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR advances the GFQL/RAPIDS GPU regression investigation in three ways:
hop()to_cugraph()fast path for contiguous zero-based integer IDsto_cugraph(), GFQL pipeline, GFQL stage-breakdown, and timing-summary comparisons across RAPIDS/CUDA variantsKept code changes
graphistry/compute/hop.pygraphistry/plugins/cugraph.pyrenumber=Falsewhen IDs are already signed integer, zero-based, and contiguousrenumber=Falsefast pathgraphistry/tests/compute/test_hop.pygraphistry/tests/plugins/test_cugraph.pyBenchmark tooling
Committed in this PR:
benchmarks/gfql/filter_pagerank/benchmark_to_cugraph_gpu.pybenchmarks/gfql/filter_pagerank/filter_pagerank_stage_breakdown_gpu.pydocker/benchmark-rapids-official-to-cugraph-gpu.shdocker/benchmark-rapids-official-gfql-gpu.shCUDA_VARIANTRUN_STAGE_BREAKDOWN=1docker/test-rapids-official-local.shWITH_BENCHMARK=1timing output asTIMING_JSON=...docker/benchmark-rapids-official-matrix.shFollow-up issues
Validation
Core validation on the kept optimization paths:
PYTHONPATH=. pytest -q graphistry/tests/plugins/test_cugraph.py graphistry/tests/compute/test_hop.py graphistry/tests/test_compute_hops.py graphistry/tests/compute/test_chain.py graphistry/tests/test_compute_chain.py196 passed, 29 skipped./bin/typecheck.shto_cugraph()explicit kwarg forwarding and ineligible-ID no-op behaviorhop()fallback-equivalence on duplicate seeds and numeric-ID topologiesGPU validation on the kept optimization paths:
hop()GPU stage-breakdown spot checks26.02-cuda13/twittersearch1_median_s:0.1121pagerank_median_s:0.0280search2_median_s:0.1043pipeline_total_median_s:0.241725.02-cuda12/twittersearch1_median_s:0.1354pagerank_median_s:0.0322search2_median_s:0.1140pipeline_total_median_s:0.3199to_cugraph()GPU conversion spot checks26.02-cuda13synthetic_contiguous: total0.0200, build0.0123,expected_vertex_match=Truesynthetic_offset: total0.0220, build0.0140,expected_vertex_match=Truesynthetic_string_gplus_shape: total0.0504, build0.0466,expected_vertex_match=Truetwitter: total0.0516, build0.0358,expected_vertex_match=True25.02-cuda12synthetic_contiguous: total0.0255, build0.0151,expected_vertex_match=Truesynthetic_offset: total0.0349, build0.0227,expected_vertex_match=Truetwitter: total0.0584, build0.0382,expected_vertex_match=TrueBenchmark-shell validation for the newly committed timing helpers:
bash -n docker/test-rapids-official-local.sh docker/benchmark-rapids-official-matrix.shCI is green on the last code-path validation head, and the benchmark-shell commit is now queued on top of it.
Findings
Accepted local wins:
hop()undirected single-hop fast pathgplusGPU pipeline improved about-40%on both RAPIDS25.02and26.02to_cugraph()fast path26.02-cuda13is consistently better than26.02-cuda12Remaining regression story:
gpluswarm pipeline,25.02-cuda12.8 -> 26.02-cuda13pipeline_total:1.7019s -> 2.1780s(+27.97%)pagerank stage:0.3240s -> 0.5108s(+57.65%)to_cugraph()+pagerank, same workloadtotal:0.8171s -> 1.3695s(+67.60%)build:0.7630s -> 1.3215s(+73.20%)pagerank:0.0537s -> 0.0487s(-9.31%)Pure RAPIDS follow-up:
synthetic_string_gplus_shape10,000,000edges107,614unique vertices25.02-cuda12.8 -> 26.02-cuda13total:0.1936s -> 0.3188s(+64.67%)build:0.1861s -> 0.3148s(+69.16%)26.02Known limits