Repository navigation
Conversation
333d0d7 made graphql_sync pass assume_not_async_iterable when check_sync is off (graphql-python#258). execute_sync was not updated, so an object that is both iterable and async-iterable, such as a Django QuerySet, took the async list path and execute_sync returned a coroutine in data with no error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #258. 333d0d7 made
graphql_syncpassassume_not_async_iterablewhencheck_syncis off, so objects that are both iterable and async-iterable (such as a Django QuerySet) are iterated synchronously. In #258 the plan was to set it "ingraphql_syncandexecute_sync", butexecute_synconly got theis_awaitablepart. It still uses the default async-iterable check, takes the async list path, and puts the coroutine intodata:A pure async generator now gives the same "Expected Iterable" field error as in
graphql_sync, instead of a coroutine indata. Withcheck_sync=Truenothing changes. The helper is duplicated inexecute.py, asassume_not_awaitablealready is, becauseexecute.pycan't import fromgraphql.py. The tests intest_sync.pycover the dual iterable, a pure async iterable, and thecheck_sync=Trueerror.The full test suite passes with the 100% coverage gate on Python 3.14, and
ruff check,ruff format --checkandmypy src testspass too. I pinned pytest below 9.2, because pytest-benchmark 5.3 errors on 9.2's benchmark fixtures.Written with AI assistance (Claude); I have reviewed the change.