Open
Conversation
martinbonnin
approved these changes
Mar 5, 2026
martinbonnin
left a comment
martinbonnin
left a comment
There was a problem hiding this comment.
LGTM! For the record, I'm also fine with just a single range. Both work for me 👍
|
One more comment: did we want to consolidate scalars in there? I think this was mentioned at some point but I'm unusure the conclusion. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@benjie this accounts for all currently proposed/in-the-works GAPs
1xxx: Directives
@mock@matches@semanticNonNull(?)2xxx: Language & Spec Extensions
Field Extensions3xxx: Ecosystem Conventions & Patterns
If a GAP is both a language extension and also a directive (like
@matches) then the more specific bucket of 1xxx: Directives should be used.(I could maybe additionally see a 0XXX range for process/meta proposals about GAPs or GraphQL itself, but for now, omitting in case of yagni.)
wdyt? trying to avoid overcomplicating but these feel sufficiently distinct, and captures everything (for now)
...and I hope to one day deal with the problem of having 999+ proposals within any of these ranges :)