Repository navigation
test(cookbook): check that examples really render, add next-js and actionlint CI - #562
Merged
Merged
Conversation
…tionlint CI The e2e suite passed even when nothing was drawn: it ignored WebGL errors and tolerated a missing canvas. It now runs real shaders on software WebGL and requires each canvas to draw several colors, with no page errors. It reads the example list from the index, and stubs imgur so an outage can't fail it. A new test also navigates through links without reloading the page. examples/next-js wasn't built by any workflow. A new job builds it and checks that its page renders. This found a real crash when building inside this repository: Next used the repository root as the project root, which next.config.js now overrides. actionlint now checks workflow changes on PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Addresses CodeQL actions/missing-workflow-permissions. Without a permissions block, these jobs inherit the default GITHUB_TOKEN permissions, and they only need to read the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cookbook e2e passed even when nothing was drawn: it ignored WebGL errors and tolerated a missing canvas.
examples/next-jswasn't built by any workflow.Changes
e2e (
pnpm e2eandpnpm e2e:prod)paintstarts blank, so the test draws on it first. It's the only special case.src/examples/index.ts, so a new example can't be left out.Next.js example
ci-next-js.ymlbuilds it and checks that the page renders (pnpm e2e:next).Cannot destructure property 'glSurface' of 'this.context'. A copy outside the repository rendered fine, so Next was using the repository root as the project root.examples/next-js/next.config.jsnow sets the root to the example. I didn't determine exactly why that root breaks the page.actionlint
ci-actionlint.ymlchecks workflow changes on PRs. It reports nothing on the current workflows.Testing
Locally, on macOS:
pnpm e2e: 51/51, twice.pnpm e2e:prod: 51/51, twice.pnpm e2e:next: passes.hellogl: fails in dev withExpected: >= 4, Received: 1.hellogl: fails in dev on the overlay, and in production on a page error and a blank canvas.Not tested:
paint.No changeset: the cookbook is private, and the Next.js example isn't published.
🤖 Generated with Claude Code