-
Notifications
You must be signed in to change notification settings - Fork 0
[flow] Upgrade from 0.281 -> 0.282 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Flow 0.280 introduced stricter type checking for `incompatible-type` errors, requiring additional $FlowFixMe suppressions alongside existing ones. Changes: - Made `QueuingStrategy` properties optional in streams.js - Made all properties optional in Web Animations API types (EffectTiming, KeyframeAnimationOptions, etc.) - Added `$FlowFixMe[incompatible-type]` alongside existing suppressions in multiple files where Flow now reports additional type mismatches
Major changes in Flow 0.281: - $FlowFixMe comments now require explicit error codes (e.g., $FlowFixMe[incompatible-type]) - Changed all bare $FlowFixMe to include appropriate error codes - Changed $FlowIgnore to $FlowFixMe where needed - Fixed stream types to have cancel() return Promise<void> instead of void - Added pseudoElement property to KeyframeEffect type - Added suppressions for Proxy handler variance issues - Fixed various type errors across the codebase
Add suppression for React\$Element incompatibility with ReactNodeList in ReactDOMRootFB.js render function. Flow 0.282 has stricter type checking for the React\$Node union type.
Greptile OverviewGreptile SummaryUpgrades Flow type checker from version 0.281 to 0.282, addressing stricter type checking requirements introduced in the new version. Key Changes:
The changes are purely mechanical, maintaining existing runtime behavior while satisfying the stricter static type checks. All suppressions appear to be justified by existing type system limitations rather than actual runtime issues. Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
59 files reviewed, no comments
Mirror of facebook/react#35331
Original author: poteto
Add suppression for React$Element incompatibility with ReactNodeList in
ReactDOMRootFB.js render function. Flow 0.282 has stricter type checking
for the React$Node union type.
Stack created with Sapling. Best reviewed with ReviewStack.