Skip to content

Conversation

@everettbu
Copy link

@everettbu everettbu commented Dec 16, 2025

Mirror of facebook/react#35371
Original author: salmanmkc


Summary

Upgrade GitHub Actions to their latest versions to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.

Changes

Action Old Version(s) New Version Release Files
actions/cache `` v5 Release
actions/checkout `` v6 Release
actions/download-artifact `` v7 Release
actions/github-script `` v8 Release
actions/setup-java `` v5 Release
actions/setup-node `` v6 Release
actions/stale `` v10 Release
actions/upload-artifact `` v6 Release

Context

Per GitHub's announcement, Node 20 is being deprecated and runners will begin using Node 24 by default starting March 4th, 2026.

Why this matters

  • Node 20 EOL: April 2026
  • Node 24 default: March 4th, 2026
  • Action: Update to latest action versions that support Node 24

Security Note

Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.

Testing

These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.

@greptile-apps
Copy link

greptile-apps bot commented Dec 16, 2025

Greptile Overview

Greptile Summary

This PR upgrades GitHub Actions to their latest versions for Node 24 compatibility ahead of Node 20's EOL in April 2026. The changes include upgrading actions/checkout (v4→v6), actions/setup-node (v4→v6), actions/cache (v4→v5), actions/download-artifact (v4→v7), actions/upload-artifact (v4→v6), actions/github-script (v7→v8), actions/setup-java (v4→v5), and actions/stale (v9→v10).

Key findings:

  • Most action upgrades are correct and consistent across all 15 workflow files
  • Issue found: actions/cache/restore and actions/cache/save remain at @v4 instead of being upgraded to @v5 to match the main actions/cache@v5 upgrade (17 occurrences in runtime_build_and_test.yml)
  • All other upgrades follow the pattern documented in the PR description
  • No breaking changes expected as these are maintenance upgrades for runtime compatibility

Confidence Score: 3/5

  • Safe to merge after addressing the cache action version inconsistency
  • The PR successfully upgrades most actions, but the inconsistent versioning of actions/cache/restore@v4 and actions/cache/save@v4 (should be v5) creates a mismatch with actions/cache@v5 throughout the codebase
  • runtime_build_and_test.yml requires attention - all 17 instances of actions/cache/restore and actions/cache/save need upgrading from v4 to v5

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/runtime_build_and_test.yml 3/5 Upgraded most actions to Node 24 compatible versions, but actions/cache/restore@v4 and actions/cache/save@v4 were not upgraded to v5
.github/workflows/compiler_playground.yml 5/5 All actions correctly upgraded to Node 24 compatible versions (checkout@v6, setup-node@v6, cache@v5, upload-artifact@v6)
.github/workflows/devtools_regression_tests.yml 5/5 All actions correctly upgraded to Node 24 compatible versions (checkout@v6, setup-node@v6, cache@v5, upload-artifact@v6, download-artifact@v7)
.github/workflows/runtime_commit_artifacts.yml 5/5 All actions correctly upgraded to Node 24 compatible versions
.github/workflows/shared_check_maintainer.yml 5/5 Correctly upgraded github-script from v7 to v8 for Node 24 compatibility

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (3)

  1. .github/workflows/runtime_build_and_test.yml, line 43 (link)

    syntax: actions/cache/restore and actions/cache/save should be upgraded to @v5 to match the main actions/cache@v5 upgrade. These are part of the same repository and should use consistent versions.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  2. .github/workflows/runtime_build_and_test.yml, line 58 (link)

    syntax: Upgrade to @v5 for consistency

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  3. .github/workflows/runtime_build_and_test.yml, line 68 (link)

    syntax: Upgrade to @v5 for consistency

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

15 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants