Skip to content

Conversation

@everettbu
Copy link

Mirror of facebook/react#35363
Original author: EugeneChoi4


Upgrading to address node-forge advisory

@greptile-apps
Copy link

greptile-apps bot commented Dec 16, 2025

Greptile Overview

Greptile Summary

Security update that upgrades node-forge from version 1.3.1 to 1.3.3 to address security advisory GHSA-5gfm-wpxj-wjgq.

  • Added yarn resolution in package.json to enforce minimum version ^1.3.2
  • node-forge is a transitive dependency used by selfsigned and @devicefarmer/adbkit
  • Version 1.3.3 is a patch release with no breaking changes
  • The caret range (^1.3.2) allows future patch updates while preventing downgrades

Confidence Score: 5/5

  • This PR is safe to merge - it's a straightforward security patch with no breaking changes
  • This is a minor version upgrade (1.3.1 → 1.3.3) that addresses a known security vulnerability. The change uses yarn resolutions to enforce the minimum version, and node-forge is only a transitive dependency. No code changes are required, and the semver-compatible upgrade has no breaking changes.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
package.json 5/5 Added yarn resolution for node-forge to enforce minimum version ^1.3.2 for security fix
yarn.lock 5/5 Updated node-forge from 1.3.1 to 1.3.3, resolving security vulnerability GHSA-5gfm-wpxj-wjgq

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants