Skip to content

Show error message in DnDTable#3955

Open
thangqp wants to merge 14 commits into
mainfrom
dnd_table_show_error_message
Open

Show error message in DnDTable#3955
thangqp wants to merge 14 commits into
mainfrom
dnd_table_show_error_message

Conversation

@thangqp
Copy link
Copy Markdown
Contributor

@thangqp thangqp commented May 21, 2026

PR Summary

Adapt to change in : gridsuite/commons-ui#1143

Signed-off-by: Thang PHAM <phamthang37@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

Warning

Review limit reached

@thangqp, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c4c736c-f69b-48a6-9ca2-507467e7b49d

📥 Commits

Reviewing files that changed from the base of the PR and between bb5ac6c and 35160bd.

📒 Files selected for processing (2)
  • src/components/dialogs/limits/limits-pane-utils.ts
  • src/components/dialogs/network-modifications/generation-dispatch/generation-dispatch-dialog.tsx
📝 Walkthrough

Walkthrough

Refactors table input error-display props and inputProps for autofocus/onBlur, and updates Yup validation schemas to add explicit minimum/required constraints and messages for temporary limits and generation-dispatch filters.

Changes

Error Display and Input Configuration Updates

Layer / File(s) Summary
Refactor error message and input prop handling in table inputs
src/components/dialogs/limits/temporary-limits-table.tsx, src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx
EditableTableCell forwards hideErrorMessage from column config to numeric and text inputs with updated TableCell styling; ColumnNameEditor passes autoFocus and onBlur via inputProps to TableTextInput instead of using showErrorMsg.
TEMPORARY_LIMIT_DURATION validation message
src/components/dialogs/limits/limits-pane-utils.ts
TEMPORARY_LIMIT_DURATION numeric validator now uses .min(0, 'mustBeGreaterOrEqualToZero') to set an explicit error message for negative values.
Generators frequency-reserve and substation filters validation
src/components/dialogs/network-modifications/generation-dispatch/generation-dispatch-dialog.tsx
Adds .min(1, 'FilterInputMinError') and required constraints to nested generator/substation filter arrays and updates the FREQUENCY_RESERVE numeric validation chain; also reorders named imports without functional change.

Suggested reviewers:

  • FranckLecuyer
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the main change: adapting components to pass error display behavior through column props to show error messages in DnD tables.
Description check ✅ Passed The description accurately references the upstream change (commons-ui PR #1143) that this PR adapts to, which is related to the changeset modifications.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants