remove unused POST /nad-positions-config endpoint and update test

[khouadrired]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a0ca7f7-60cc-49ca-959e-3e5372f64c4d

📥 Commits

Reviewing files that changed from the base of the PR and between 3dfb2d7 and 95ece73.

📒 Files selected for processing (5)

• src/main/java/org/gridsuite/study/server/controller/StudyController.java
• src/main/java/org/gridsuite/study/server/service/SingleLineDiagramService.java
• src/main/java/org/gridsuite/study/server/service/StudyService.java
• src/test/java/org/gridsuite/study/server/StudyServiceTest.java
• src/test/java/org/gridsuite/study/server/utils/wiremock/WireMockStubs.java

💤 Files with no reviewable changes (3)

• src/test/java/org/gridsuite/study/server/utils/wiremock/WireMockStubs.java
• src/main/java/org/gridsuite/study/server/service/StudyService.java
• src/main/java/org/gridsuite/study/server/controller/StudyController.java

---

📝 Walkthrough

Walkthrough

This PR removes the NAD positions CSV upload flow: it deletes controller endpoint, service methods and constants, and corresponding tests and WireMock helpers.

Changes

NAD CSV Upload Feature Removal

Layer / File(s)	Summary
Service layer method and constant removal src/main/java/org/gridsuite/study/server/service/SingleLineDiagramService.java, src/main/java/org/gridsuite/study/server/service/StudyService.java	SingleLineDiagramService switches to explicit HTTP imports, removes unused constants and deletes addParameters and createNadPositionsConfigFromCsv. StudyService deletes createNadPositionsConfigFromCsv.
Controller endpoint removal src/main/java/org/gridsuite/study/server/controller/StudyController.java	Removes the POST /studies/network-visualizations/nad-positions-config endpoint and the MultipartFile import.
Test and WireMock stub cleanup src/test/java/org/gridsuite/study/server/StudyServiceTest.java, src/test/java/org/gridsuite/study/server/utils/wiremock/WireMockStubs.java	StudyServiceTest drops MockMvc/WireMock setup, testImportCsv, and lifecycle methods; WireMockStubs removes URI_NETWORK_AREA_DIAGRAM and CSV stub/verification helpers.

Suggested reviewers

• antoinebhs
• SlimaneAmar

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset.	Add a description explaining the rationale for removing the endpoint, any deprecation period, and migration guidance for dependent services if applicable.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removal of the unused POST /nad-positions-config endpoint and associated test updates across multiple files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[antoinebhs]

very nice to clean this

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud