enable child channel plugins #12578
Draft
enable child channel plugins #12578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgraVator
commented
Dec 23, 2025
Comment on lines
34
to
37
| ObjectPool<XdsClient> getOrCreate( | ||
| String target, BootstrapInfo bootstrapInfo, MetricRecorder metricRecorder, | ||
| ManagedChannel parentChannel); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Should this be a generic object instead of ManagedChannel ?
AgraVator
commented
Dec 29, 2025
Comment on lines
147
to
+149
| return new XdsServerWrapper("0.0.0.0:" + port, delegate, xdsServingStatusListener, | ||
| filterChainSelectorManager, xdsClientPoolFactory, bootstrapOverride, filterRegistry); | ||
| filterChainSelectorManager, xdsClientPoolFactory, bootstrapOverride, filterRegistry, | ||
| this.childChannelConfigurer); |
Contributor
Author
There was a problem hiding this comment.
Why does this not pass the builder object ?
kannanjgithub
approved these changes
Jan 6, 2026
| @@ -0,0 +1,70 @@ | |||
| /* | |||
| * Copyright 2025 The gRPC Authors | |||
Comment on lines
+63
to
+64
| * universal configuration methods (like {@code intercept()}, {@code userAgent()}) rather | ||
| * than casting to specific implementation types. |
Contributor
There was a problem hiding this comment.
Suggested change
| * universal configuration methods (like {@code intercept()}, {@code userAgent()}) rather | |
| * than casting to specific implementation types. | |
| * universal configuration methods (like {@code intercept()}, {@code userAgent()}) on the builder rather | |
| * than casting it to specific implementation types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.