Skip to content

Make services table height responsive#115

Open
Jxl-s wants to merge 1 commit into
developfrom
feature/97-services-table-height
Open

Make services table height responsive#115
Jxl-s wants to merge 1 commit into
developfrom
feature/97-services-table-height

Conversation

@Jxl-s

@Jxl-s Jxl-s commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Closes #97

Overview

The services table previously used min-h-screen, causing the page to
scroll rather than the table paginating within the viewport. This PR
mirrors the pattern already used by the users and forms pages: a bounded
layout.tsx establishes the height context, the page and ServicesTable
propagate a flex/overflow chain, and UsersDataTable (which uses a
ResizeObserver to compute page size from available height) replaces the
static DataTable.

Testing

Manually resized the browser window vertically on /services and
confirmed the table shows fewer rows as the viewport shrinks, with
pagination updating accordingly. Verified the behaviour matches /users.

Screenshots / Screencasts

Screen.Recording.2026-06-26.at.11.39.49.PM.mov

Checklist

  • Code is neat, readable, and works
  • Code is commented where appropriate and well-documented
  • Commit messages follow our guidelines
  • Issue number is linked
  • Branch is linked
  • Reviewers are assigned (one of your tech leads)

Notes

N/A

@Jxl-s Jxl-s marked this pull request as ready for review June 27, 2026 06:41

@RenaudBernier RenaudBernier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Jia.
Please check the boxes in the PR template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants