Make services table height responsive#115
Open
Jxl-s wants to merge 1 commit into
Open
Conversation
RenaudBernier
approved these changes
Jun 27, 2026
RenaudBernier
left a comment
Member
There was a problem hiding this comment.
Good work Jia.
Please check the boxes in the PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
Overview
The services table previously used
min-h-screen, causing the page toscroll rather than the table paginating within the viewport. This PR
mirrors the pattern already used by the users and forms pages: a bounded
layout.tsxestablishes the height context, the page andServicesTablepropagate a flex/overflow chain, and
UsersDataTable(which uses aResizeObserverto compute page size from available height) replaces thestatic
DataTable.Testing
Manually resized the browser window vertically on
/servicesandconfirmed the table shows fewer rows as the viewport shrinks, with
pagination updating accordingly. Verified the behaviour matches
/users.Screenshots / Screencasts
Screen.Recording.2026-06-26.at.11.39.49.PM.mov
Checklist
Notes
N/A