-
-
Notifications
You must be signed in to change notification settings - Fork 872
ER: Remove unused search id query selectors #8803
Copy link
Copy link
Open
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueDraftIssue is still in the process of being createdIssue is still in the process of being createdEREmergent RequestEmergent RequestIssue Making: Level 1Make issues from a template and a spreadsheetMake issues from a template and a spreadsheetP-Feature: Projects pagehttps://www.hackforla.org/projects/https://www.hackforla.org/projects/ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritizationneeds a senior review either to do some re writing or to approve it for ready for prioritizationrole: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Description
Activity
Metadata
Metadata
Assignees
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueDraftIssue is still in the process of being createdIssue is still in the process of being createdEREmergent RequestEmergent RequestIssue Making: Level 1Make issues from a template and a spreadsheetMake issues from a template and a spreadsheetP-Feature: Projects pagehttps://www.hackforla.org/projects/https://www.hackforla.org/projects/ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritizationneeds a senior review either to do some re writing or to approve it for ready for prioritizationrole: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Type
Projects
- StatusShow more project fieldsNew Issue Approval
Emergent Requirement - Problem
In
assets/js/current-projects.js, there are three query selectors that select an id namedsearch. However, in_includes/current-projects.html, there is no id forsearch.We must remove any query selectors for
searchinassets/js/current-projects.jssince it is an unused id.Issue you discovered this emergent requirement in
Date discovered
9/19/2026
Did you have to do something temporarily
Who was involved
@ldaws003 @castillios
What happens if this is not addressed
Any deprecated IDs may continue to bloat the codebase if left unaddressed.
Resources
Recommended Action Items
Potential solutions [draft]
Create a small issue that lists the 3 instances of
document.querySelector('#search')and their corresponding line numbers to be removed fromassets/js/current-projects.js.In your issue body under the
Instructionssection, include before and after code snippets as follows:Line 105 before:
Line 105 after removing
document.querySelector('#search'):Lines 344-348 before:
Lines 344-348 after removing
document.querySelector('#search'):Lines 376-380 before:
Lines 376-380 after removing
document.querySelector('#search'):After listing implementation details, include an action item to test and verify that the changes still work by performing a search in both mobile and desktop views on the Projects and Projects-Check pages
Ensure your issue labels match this parent ER (with the exception of
Issue Making: Level 1andER)Once the overall issue has been drafted, in the sidebar under Relationships, add this ER as a parent to your issue
Review and if ready, apply the
ready for merge teamlabel