Repository navigation
Upgrade build tooling and migrate frontend assets to Gradle - #67
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move frontend asset generation into the Gradle resource lifecycle and align the project with the current Halo plugin scaffold.
packagesboth a Gradle subproject and the pnpm workspace root, using pnpm 12.processResources.The npm library remains ESM, and the theme bundle retains
SearchWidget.open()and its existing asset URLs.Compatibility
The minimum supported Halo version increases from 2.17 to 2.26. Upgrade Halo before installing this plugin version.
Validation
Passed with the final pnpm 12.10.1 configuration:
pnpm -C packages install --frozen-lockfile./gradlew clean buildwith Java 21pnpm -C packages checkpnpm -C packages/search-widget exec tsc --noEmit -p tsconfig.test.jsonpnpm -C packages test— all 11 browser tests passedgit diff --checkAdditional checks performed during the migration covered incremental frontend builds, a Chromium smoke test of the production IIFE bundle, JAR asset contents, stale resource cleanup, exclusion of legacy source-directory assets, frozen-lockfile rejection after changing a workspace dependency manifest, and an npm package dry run.
A full Halo runtime test and remote GitHub Actions execution have not been performed. The build retains an upstream DevTools Gradle deprecation warning.