-
Notifications
You must be signed in to change notification settings - Fork 160
HF-24: add stringifyCurrency config callback for TEXT #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcin-kordas-hoc
wants to merge
42
commits into
develop
Choose a base branch
from
feature/hf-24-stringify-currency
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
b17acc9
Feature: HF-24 introduce defaultStringifyCurrency
marcin-kordas-hoc 7a0f836
Feature: HF-24 declare stringifyCurrency on ConfigParams interface
marcin-kordas-hoc 19ebe26
Feature: HF-24 wire stringifyCurrency through Config class
marcin-kordas-hoc e2b2b52
Feature: HF-24 dispatch stringifyCurrency in format()
marcin-kordas-hoc 4d1a7a9
Docs: HF-24 add Currency integration section to date-and-time guide
marcin-kordas-hoc 5124c12
Docs: HF-24 changelog entry for stringifyCurrency
marcin-kordas-hoc ac5dc89
Fix: HF-24 correct CHANGELOG issue ref and clarify docs adapter
marcin-kordas-hoc f47ca12
Docs: HF-24 strip {type} JSDoc tags from defaultStringifyCurrency
marcin-kordas-hoc 4a48ea7
Docs: HF-24 align stringifyCurrency JSDoc @category with sibling stri…
marcin-kordas-hoc fe2fb44
Chore: HF-24 retrigger codecov upload
marcin-kordas-hoc 39967c8
Docs: HF-24 align currency-integration text with PR body (drop count …
marcin-kordas-hoc 10be7fe
Docs: HF-24 final cross-doc polish (TEXT xref, currency callback diff…
marcin-kordas-hoc ca91f3a
Docs: HF-24 wrap NBSP note in :::tip callout for discoverability
marcin-kordas-hoc 08f0267
Docs: HF-24 redesign Currency integration for friction elimination
marcin-kordas-hoc 79abac4
Fix: HF-24 dispatch stringifyCurrency before stringifyDateTime to pre…
marcin-kordas-hoc e23818a
Fix: HF-24 skip date dispatch for LCID-tagged currency formats
marcin-kordas-hoc 9d4c1a6
Fix: HF-24 narrow LCID guard to currency tags only (preserve [$-LCID]…
marcin-kordas-hoc 0990c09
Fix: HF-24 add LCID guard to defaultStringifyDuration (sibling consis…
marcin-kordas-hoc 9171146
Docs: HF-24 clarify dispatcher comment after LCID guard introduction
marcin-kordas-hoc 378c077
Chore: HF-24 retrigger CI after tests-repo develop merge
marcin-kordas-hoc 6997cc4
Docs: HF-24 correct default behavior claims for currency formats
marcin-kordas-hoc 9c349ac
Docs: HF-24 split currency handling into dedicated guide
marcin-kordas-hoc ca650a9
Chore: HF-24 retrigger CI for docs-only iter on f1eb4efb2
marcin-kordas-hoc a4b05ae
Docs: HF-24 unify currency input/output in currency-handling guide
marcin-kordas-hoc f6cac82
Refactor: HF-24 address prep-ultra polish (category, regex hoist, docs)
marcin-kordas-hoc 9570581
Docs: HF-24 enrich JSDoc for default stringify guards (LCID design in…
marcin-kordas-hoc e3f7368
Tools: HF-24 snippet codegen — close O5 docs↔test source-of-truth gap
marcin-kordas-hoc 4597aa0
Tools: HF-24 wire snippets:check into the lint CI workflow
marcin-kordas-hoc cd7680d
Tools: HF-24 close 7 review findings from A+C parallel review
marcin-kordas-hoc f66fd41
chore: HF-24 retrigger CI to pick up tests-repo fix (ed38a4f)
marcin-kordas-hoc e1f3091
Docs: HF-24 revert tryAccountingFormat sign-loss "fix" — pre-fix matc…
marcin-kordas-hoc 3e8e496
chore: HF-24 retrigger CI for tests-repo dead-code drop (87e72b5)
marcin-kordas-hoc 85c7733
HF-24 final pre-flip cleanup: lint + Excel parity + CHANGELOG
marcin-kordas-hoc 23ffc97
Cleanup: HF-24 two minor refinements from line-by-line audit
marcin-kordas-hoc 1a40b26
HF-24 brutal-honesty cleanup: CHANGELOG section + codegen docstring
marcin-kordas-hoc b91d125
HF-24 retrigger CI to pick up tests-repo lint fix 6ebdbf8
marcin-kordas-hoc 139d76a
HF-24 retrigger CI for tests-repo lint+xdescribe fix (8c87bbe)
marcin-kordas-hoc cbdd9fd
docs(HF-24): address review threads — LCID Excel behavior, double-quo…
marcin-kordas-hoc cb2fa8f
Docs: HF-24 add .md extension to bare slug links in built-in-functions
marcin-kordas-hoc 69d5916
Merge branch 'develop' into feature/hf-24-stringify-currency
sequba cd024e7
fix(HF-24): generate doc snippets at test time; changelog & docs polish
marcin-kordas-hoc 24b2a20
ci(HF-24): note snippet pre-generation in test workflow
marcin-kordas-hoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,5 +24,6 @@ lib | |
| script | ||
| test-jasmine | ||
| test-jest | ||
| test-utils/snippets | ||
| typedoc | ||
| typings | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||||
| ### Added | ||||||
|
|
||||||
| - Added an Indonesian (Bahasa Indonesia) language pack. [#1674](https://github.com/handsontable/hyperformula/pull/1674) | ||||||
| - Added a `stringifyCurrency` config option that lets you plug in a custom currency formatter for the `TEXT` function. [#1145](https://github.com/handsontable/hyperformula/issues/1145) | ||||||
| - Added support for LCID-tagged currency format strings (e.g. `[$USD-409] #,##0.00`) in the `TEXT` function. Previously the date-time parser greedily consumed letter tokens inside the currency code (`D` in USD, `H` in CHF/HUF, etc.), producing corrupted output like `[$US9-409]`; such formats now fall through to the number formatter (or a user-supplied `stringifyCurrency` callback), regardless of whether `stringifyCurrency` is configured. [#1665](https://github.com/handsontable/hyperformula/pull/1665) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ## [3.3.0] - 2026-05-20 | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
pretest:ciis never run. I suggested the change to the npm scripts to run it before actual tests