refactor: modernize build system, add tests, CI, and auto-versioning#1
Open
halfguru wants to merge 1 commit into
Open
refactor: modernize build system, add tests, CI, and auto-versioning#1halfguru wants to merge 1 commit into
halfguru wants to merge 1 commit into
Conversation
24a3977 to
f107b78
Compare
Complete overhaul of the procon2droid Magisk module with modern tooling: Build System - Replace monolithic source files with CMake + Ninja build - Add CMakePresets.json for native (tests) and Android cross-compile - Auto-generate module.prop from CMake version via configure_file Code Quality - Restructure src/ into common/, enable/, rumble/ - Modern C++20: constexpr, std::array, std::span, std::optional, std::copy - Use std::unique_ptr with custom deleter for DIR* RAII - Add const correctness, standard EXIT_SUCCESS/EXIT_FAILURE return codes - Add file header comments explaining each component Testing - Add 18 Catch2 tests for init sequence and haptic report - Tests run natively on Windows/macOS/Linux via CMake presets CI/CD - GitHub Actions: lint (clang-format + clang-tidy), test, Android cross-compile - Use egor-tensin/setup-clang@v2 for consistent LLVM 22 tooling - Cross-compile for arm64-v8a and armeabi-v7a with NDK r27c - Auto-strip Android binaries, package Magisk zips on releases Service Script - Replace pgrep substring matching with PID file tracking - Add timestamped logging, cleanup traps, binary sanity checks - Handle enable exit status and controller removal gracefully Tooling - Add .clang-format (LLVM style), .clang-tidy with suppressions - Add .gitignore, .gitattributes with LF normalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete overhaul of the procon2droid Magisk module with modern tooling and practices.
Changes
Build System
Code Quality
Testing
CI/CD
Service Script
Tooling