[UI] remove ember render modifier#23079
Closed
suresh-hashicorp wants to merge 14 commits intomainfrom
Closed
Conversation
- Convert from classic Ember component to Glimmer component - Replace Component.extend() with ES6 class syntax - Use @Tracked decorator for isConfirmation property - Use @action decorator instead of actions hash - Replace next() with schedule('afterRender') for clarity - Replace set() with direct property assignment - Remove Slotted mixin (not needed in Glimmer) - Update template to use {{on-insert this.connect}} - Maintain backward compatibility with no-op change function
…on; add a11y-dialog modifier;
suresh-hashicorp
force-pushed
the
suresh/ui/remove-ember-render-modifier
branch
from
c3d942e to
4525d8a
Compare
* all tests fixed * code cleanup * fix minor issue * adds changelog * remove redundant fn usage * fixes assert equal issues * ppnpm lock update * avoid crashing on error * fixes lint issue * revert * test change * fix torii provider baseUrl assertion without changing SSO flow * linting fix * route import change --------- Co-authored-by: Rishabh Gupta <rishabh.gupta@hashicorp.com>
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
Bot
added
the
meta/stale
|
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing & Reproduction steps
Links
PR Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.