Update Rust crate bump-scope to v2#8695
Conversation
PR SummaryMedium Risk Overview Regenerates Reviewed by Cursor Bugbot for commit 404c318. Bugbot is set up for automated code reviews on this repo. Configure here. |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| bon = { version = "3.8.1", default-features = false, features = ["implied-bounds"] } | ||
| bstr = { version = "1.12.1" } | ||
| bump-scope = { version = "1.5.1", default-features = false, features = ["alloc", "nightly-clone-to-uninit", "panic-on-alloc", "std"] } | ||
| bump-scope = { version = "2.0.0", default-features = false, features = ["alloc", "nightly-clone-to-uninit", "panic-on-alloc", "std"] } |
There was a problem hiding this comment.
bump-scope v2 changed scoped to call the closure with &mut BumpScope (instead of an owned BumpScope), but libs/@local/hashql/core/src/heap/allocator.rs currently appears to assume an owned scope (AllocatorScope(scope)), so this bump may break hashql-core’s allocator wrappers.
Please double-check those wrappers against the v2 API (e.g., whether converting via by_value() is required) before merging.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8695 +/- ##
=======================================
Coverage 62.08% 62.08%
=======================================
Files 1341 1341
Lines 135072 135072
Branches 5744 5744
=======================================
+ Hits 83854 83856 +2
+ Misses 50310 50308 -2
Partials 908 908
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR contains the following updates:
1.5.1→2.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
bluurryy/bump-scope (bump-scope)
v2.3.0Compare Source
Added
{BumpVec, BumpString}::shrink_toChanged
retain(using std's new implementation)alloc_iter*,alloc_fmt*andshrink_to_fit(by makingshrink_to_fitexit early when capacity and length are the same)Fixed
"nightly-clone-to-uninit"and without"panic-on-alloc"v2.2.0Compare Source
Added
BumpPool::reset_to_startChanged
reset,reset_to_start,by_valueand cratev2.1.0Compare Source
Added
Bump::reset_to_startto reset the bump allocator without deallocating chunks(try_)push_mut(_with)method to vector types(try_)insert_mutmethod to vector typesChanged
Deprecated
push_with_unchecked, usepush_uncheckedinsteadv2.0.0Compare Source
Added
claimapi that allows you to enter scopes from a shared referenceSHRINKSsetting, to toggle shrinking for the allocation api,DEALLOCATESno longer affects shrinkingMINIMUM_CHUNK_SIZEsetting(try_)by_valueto turn a&mut BumpScopeinto aBumpScopescope_guard,scoped(_aligned)available for non-guaranteed-allocated allocatorsBump(Scope)now also available via traits in the newtraitsmoduleChanged
Settingsparameterscoped,scoped_alignedandalignedto take a closure with&mut BumpScopeinstead ofBumpScope(you can get the bump scope by value usingby_value)(borrow_(mut_)with_settingsmethodsbytemuckandzerocopyallocator extension traits for allT: BumpAllocatorTypedScopeand name themBumpAllocatorTypedScopeExtreserve_bytestoreserve(Mut)BumpAllocator->traits::(Mut)BumpAllocatorCore(Mut)BumpAllocatorScope->traits::(Mut)BumpAllocatorCoreScope(Mut)BumpAllocatorTypedScopeExt->traits::(Mut)BumpAllocatorTyped(Mut)BumpAllocatorScopeExt->traits::(Mut)BumpAllocatorTypedScopeBumpAllocatorCoretrait safety invariantsprepare_allocation_revand require it forallocate_prepared_rev, safety invariants for the prepare allocation api changedDefaultimplementation ofBump(Scope)s which are!GUARANTEED_ALLOCATEDto not allocateBump(Scope), checking for a layout of0serde_coreinstead ofserdeRemoved
into_aligned, usewith_settingsas_mut_aligned, useborrow_mut_with_settings{as, as_mut, into}_guaranteed_allocated, usereserve+*with_settingsalloc_layout(allocate_layoutprovides the same functionality)Fixed
no_stdbuilds with "serde" feature by depending on serde without default featuresBump(Scope)::reserve_bytesConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.