Open "ClientMapTest::test*Ttl* tests" [HZ-5311]#1444
Open "ClientMapTest::test*Ttl* tests" [HZ-5311]#1444ihsandemir wants to merge 4 commits intohazelcast:masterfrom
Conversation
- Opened "ClientMapTest::test*Ttl* tests" [HZ-5311] - Enhanced ClientMapTest to use structured client configuration parameters. fixes hazelcast#1390
There was a problem hiding this comment.
There is no publish 5.7.0-SNAPSHOT artifact. Is it a good idea for the client to require this? It might make community contributions more difficult.
There was a problem hiding this comment.
you can start the rc with environment HZ_VERSION, hence, any community can use any version. This is the only version that can work with the latest PR changes, hence, we need it.
There was a problem hiding this comment.
Shouldn't we also update (e.g.!)
There was a problem hiding this comment.
The change is fine, but the PR builder is failing - I don't think (private) OS SNAPSHOTs are supported.
Supporting this is non-trivial, and I have concerns about how a non-Hazelcast user would test this locally. Can we wait for 5.7.0 release before this PR?
2 participants
refactor:
Opened "ClientMapTest::testTtl tests" HZ-5311
Enhanced ClientMapTest to use structured client configuration parameters which is better printed in the test names.
fixes #1390