Skip to content

Use Boost::json in olp-cpp-sdk-dataservice-write#1677

Draft
rustam-gamidov-here wants to merge 2 commits intofeature_boost_jsonfrom
rga/ocmam-445-boost-json-to-write
Draft

Use Boost::json in olp-cpp-sdk-dataservice-write#1677
rustam-gamidov-here wants to merge 2 commits intofeature_boost_jsonfrom
rga/ocmam-445-boost-json-to-write

Conversation

@rustam-gamidov-here
Copy link
Collaborator

Migrating from RapidJSON
Temporary introduced boost_parser to keep same names and replace rapidjson based parser with this boost based when core is done

Relates-To: OCMAM-445

Migrating from RapidJSON

Relates-To: OCMAM-445
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating from RapidJSON
Temporary introduced boost_parser to keep same names and later
replace rapidjson based parser with this boost based.

Relates-To: OCMAM-445
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 89.21933% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature_boost_json@5d52332). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...e/src/generated/serializer/IndexInfoSerializer.cpp 66.67% 8 Missing and 2 partials ⚠️
...erated/serializer/UpdateIndexRequestSerializer.cpp 72.73% 7 Missing and 2 partials ⚠️
.../olp/core/generated/serializer/SerializerWrapper.h 92.31% 0 Missing and 2 partials ⚠️
...src/generated/serializer/PublicationSerializer.cpp 90.91% 0 Missing and 2 partials ⚠️
...ore/include/olp/core/generated/parser/JsonParser.h 85.71% 1 Missing ⚠️
.../include/olp/core/generated/parser/ParserWrapper.h 96.30% 0 Missing and 1 partial ⚠️
...-cpp-sdk-dataservice-write/src/CatalogSettings.cpp 0.00% 1 Missing ⚠️
...dk-dataservice-write/src/StreamLayerClientImpl.cpp 0.00% 1 Missing ⚠️
...ite/src/generated/parser/VersionResponseParser.cpp 0.00% 1 Missing ⚠️
...nerated/serializer/PublishPartitionsSerializer.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feature_boost_json    #1677   +/-   ##
=====================================================
  Coverage                      ?   80.52%           
=====================================================
  Files                         ?      351           
  Lines                         ?    14067           
  Branches                      ?     1525           
=====================================================
  Hits                          ?    11327           
  Misses                        ?     2122           
  Partials                      ?      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rustam-gamidov-here rustam-gamidov-here marked this pull request as draft March 5, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant