Repository navigation
Remove hex_api_release:get_staged/2 - #257
Merged
Merged
Conversation
The staged release responses from Hex.pm carry the status endpoint's URL in `url`, and clients poll that URL. get_staged/2 built the path from the staged release id, which ties clients to a URL layout the server owns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hex_api_release:get_staged/2built a staged release's status path from its id:/staged-releases/:id, or/repos/:repo/staged-releases/:id. hexpm/hexpm#2095 removes the id from staged release URLs, so that path stops existing. Clients poll theurlthe publish response returns instead, which is what Hex'smix hex.publish --waitnow does. The function came in with #255 and hasn't been released. This removes it with its test and fixtures.rebar3 ctpassed 293 tests with 1 skipped (hex_oidc_SUITE:put_audience_no_query_test, which skips itself when thejsonmodule is available),rebar3 as test properpassed 5 properties, andrebar3 fmt --checkis clean, on daea875.