Skip to content

test(studio): quarantine the seqplainkeys cases whose undo sometimes leaves the box off #6990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrusso1020 merged 3 commits into from
Nov 2, 2026
Merged

test(studio): quarantine the seqplainkeys cases whose undo sometimes leaves the box off #6990

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f0f8c0
test(studio): quarantine the seqplainkeys case whose undo sometimes l…
jrusso1020 Nov 2, 2026
cdb503e
test(studio): quarantine the two sibling seqplainkeys center cases wi…
jrusso1020 Nov 2, 2026
e0c9844
test(studio): quarantine the pct and px seqplainkeys cases with the s…
jrusso1020 Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/studio/tests/e2e/edit-accuracy/ratchet.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,17 @@ export function bankable(runs) {
* Cases a real Studio race flips run to run, with the PR fixing it: measured and listed every run, never gated.
* The fixing PR deletes its own ids here and re-banks them in the same PR.
*/
export const QUARANTINED = {};
export const QUARANTINED = {
// Undo or redo of a keyframed plain element restores the bytes but sometimes leaves the box 230-400px off.
"seqplainkeys-none-center-r0-nested-z100": "#6989",

@heygengenesis heygengenesis Bot Nov 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment() renders this value as (fixed by #6989), and that line is already in this PR's sticky comment. #6989 is the open issue, not a fix, so a reader skimming a later PR comment will think the race is fixed. Two ways to handle it: relabel the line tracked by in comment(), which means updating the ratchet.test.mjs:79-80 expectation too, or just accept the wording until the fixing PR swaps in its own number.

"seqplainkeys-none-center-r0-root-z100": "#6989",
"seqplainkeys-none-center-r30-root-z100": "#6989",
"seqplainkeys-none-pct-r0-root-z100": "#6989",
"seqplainkeys-none-pct-r30-root-z100": "#6989",
"seqplainkeys-none-px-r0-nested-z100": "#6989",
"seqplainkeys-none-px-r30-nested-z100": "#6989",
"seqplainkeys-none-px-r30-root-z100": "#6989",
};

/**
* Every run of every case: each shard's run plus the re-runs of the cases it flipped. `scope`, for a run of
Expand Down
Loading