Repository navigation
chore: release v0.9.32 - #7520
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
There was a problem hiding this comment.
Requesting changes at a40893ba. The release would publish code that its notes leave out and its gate never ran.
Blocker: main has moved past the release branch's base. This branch sits on 7ff8ece46 (#7517). Since then, two more commits have landed on main:
b37e4b026fix(share): publish fallback locks with their owner (#7516). This is a code change:packages/share/src/projectLock.mjs+151/−41, new tests, and ascripts/package-size-budgets.jsonchange.717d3d02cdocs(readme): GitHub rank and skills downloads badges (#7519).
publish.yml checks out and tags github.event.pull_request.merge_commit_sha, and that commit is built on current main. So if this merges as is, v0.9.32 publishes @hyperframes/share with #7516 in it, while:
- the PR body,
releases/v0.9.32.mdanddocs/changelog.mdxsay the release "carries the nine changes since v0.9.31 and nothing else", and #7516 is not in any of them; - the release gate and the render off the packed packages ran on a tree without #7516, so the published share package and the size budgets were never checked in this release;
- the notes'
v0.9.31...v0.9.32compare link will list 11 commits against 9 notes.
To clear it: rebase onto current main, then re-run changelog:draft 0.9.32 --from v0.9.31 and release:prepare. Add #7516 under Fixes (Share:) and decide where #7519 goes (Docs, or leave it out as the README-only change it is). Update the PR body's count, then re-run the release gate and the packed-package render on the new head.
Otherwise checked, and fine:
- The diff outside the notes is exactly 20
"version": "0.9.31"→"0.9.32"lines across 15 packages and 5 plugin manifests. - The nine notes entries match
v0.9.31..7ff8ece46one to one, with correct commit SHAs and PR links. - The #7517 line matches what that PR does: at least 5 min, twice the start-up, at most 15 min.
70e1924 to
956ac09
Compare
956ac09 to
6944b9d
Compare
6944b9d to
9fc0a13
Compare
There was a problem hiding this comment.
Approving at 9fc0a130. The blocker from my last review is cleared.
What I checked
- Up to date with main. The release commit's parent is
499a17e67(#7527), which is currentorigin/main.v0.9.31..mainhas 16 commits, and the release adds exactly one commit on top. - The notes cover every change. All 16 PRs appear with correct commit SHAs and links in both
releases/v0.9.32.mdanddocs/changelog.mdx: #7527, #5820, #7522, #6010, #6011, #7519, #7516, #7517, #7514, #7515, #7507, #7508, #7510, #7512, #7511 and #7509. The PR body lists the same 16. - The version diff is clean. Outside the notes, the diff is exactly 20
"version": "0.9.31"→"0.9.32"lines, 22 files in all, the same shape as the v0.9.31 release. - Spot checks. The
--chroma-subsampling 444flag in the #5820 line exists inpackages/cli/src/commands/render.ts("420" | "444"). #6010 is filed under Internal, and #7519 and #7527 under Docs & Examples.
Conditions
- CI, CodeQL, Docs and the Lambda arm64 image were still running on this head when I reviewed, and the merge state is
BLOCKEDuntil they finish. This approval assumes they and the release gate go green. publish.ymltags the merge commit. If anything else lands onmainbefore this merges, the merge commit will contain changes the notes leave out, so cut the release again rather than merging on this approval.
Nit, not blocking: the summary paragraph at the top of the notes mentions only the first-frame fix and the hardening work. The share lock fix and opt-in 4:4:4 are in the PR's "Why" but not in that paragraph.
9fc0a13 to
e4167d1
Compare
There was a problem hiding this comment.
Approving at e4167d1c, reviewed as the delta from 9fc0a130, which I approved last time. No blockers.
The delta is what the PR says it is
- Up to date with main. The release commit's parent is
941049a84(#7531), which is currentorigin/main. The only commit on main since the previous cut's base (499a17e67) is #7531. - #7531 is share-only:
packages/share/src/reviewExport.mjs,reviewVersionSentences.mjs,README.mdandtests/reviewPersistence.test.mjs. It touches no engine, producer, CLI or package manifest. It merged through the merge queue withCI [merge_group],regressionandWindows render verificationgreen. - Release commit versus the last cut:
range-diffshows the only changes are the #7531 bullet under Fixes in bothreleases/v0.9.32.mdanddocs/changelog.mdx, and the changelogtags(addsShare, dropsREADME). The rest of the diff is still exactly 20"version": "0.9.31"→"0.9.32"lines across 22 files. - Share tests on this head:
node --test tests/*.test.mjsinpackages/sharepasses 57/57 locally.
Gate state, as Actions shows it
- On
9fc0a130,CIwas cancelled once this head was pushed, after 10 jobs passed, includingRelease checks. Two Catalog jobs were cancelled.regression,Docs,Lambda arm64 image,preview-regressionandWindows render verificationall passed there. I can't see the full release gate you mention from Actions, so this approval relies on your report that it passes on that cut. - On
e4167d1c,regression,PR captures,Windows render verification,preview-regressionand both player perf runs are green.CI,Docs,Lambda arm64 imageandCodeQLare still running. This approval assumes they finish green.
Nit, not blocking: the #7531 bullet is the raw commit title ("Guide recovery when an export replay is refused"). Your other share lines are in plain words, saying what the user sees.
Same standing condition as before: if anything else lands on main before this merges, the merge commit publish.yml tags will contain a change the notes leave out, so cut it again.
What
Release v0.9.32: a version bump of all packages and plugin manifests, the changelog entry and
releases/v0.9.32.md.It carries the seventeen changes since v0.9.31 and nothing else:
workersnow gets a 400 instead of a 500, and a rejected request frees its render slot..hyperframesor.thumbnails; if.hyperframesitself is a link, project history stays off for that project, with a warning.PATH, not the working directory; the documented.hyperframes/binand@ffmpeg-installerFFmpeg lookups stay.lambda destroy, snapshot media,upgradeand project file serving are hardened.lambdacommands refuse a state file recorded for a different stack name.--chroma-subsampling 444, for masters that will be re-encoded; the default is unchanged.sandbox="allow-scripts"), so a composition's scripts cannot reach into Studio.Why
Ships the first-frame wait fix for long, mostly still films, the share lock fix, opt-in 4:4:4 chroma, and the hardening changes merged since v0.9.31.
Related work
Follows
chore: release v0.9.31(#7506).How
bun run changelog:draft 0.9.32 --write --from v0.9.31, then the generated TODO summary was written and the style-bar line removed in both notes files, and the #7517, #7516, #6011, #5820 and #7522 lines were put in plain words. Thenbun run release:prepare 0.9.32 --from v0.9.31 --no-tagset 15 packages and 5 plugin manifests to 0.9.32. The changed file list matches the v0.9.31 release commit (22 files). No tag is pushed; the release workflow tags the merge SHA.Release gate
The full release gate (Desktop's full walk with these packed packages) runs on the previous cut,
9fc0a130, which holds every change here except #7531. #7531 changes onlypackages/share(reviewExport.mjs,reviewVersionSentences.mjs, their test and README), so on this head the checks that cover it are: this pull request's Build, the share package's own tests, and a render with the packed CLI. Links below as they finish.9fc0a130: pendingNo visible change
Version bump and changelog only. Each change was captured in its own PR.
Test plan
docs/changelog.mdxandreleases/v0.9.32.md, summary written by hand