fix(serve-static): Add error handling in createStreamBody #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unhandled 'error' event in createStreamBody, which caused Hono server to crash when attempting to serve an existing file without read permission. Now, such errors are properly handled to prevent server crashes.
yusukebe
changed the title
Member
|
Hi @thongdoan Thank you for the PR. I added the test myself. Looks good. I'll merge this and release a new version. |
Contributor
Author
|
Thank you for merging and also for adding the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unhandled 'error' event in createStreamBody, which caused Hono server to crash when attempting to serve an existing file without read permission. Now, such errors are properly handled to prevent server crashes.