Add graceful shutdown and error handling#779
Merged
KernelDeimos merged 19 commits intohttp-party:masterfrom Dec 19, 2025
Merged
Add graceful shutdown and error handling#779KernelDeimos merged 19 commits intohttp-party:masterfrom
KernelDeimos merged 19 commits intohttp-party:masterfrom
Conversation
Currently not functional due to switch not working
Contributor
Author
|
Ready for review. |
thornjad
requested changes
May 31, 2022
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
zbynek
suggested changes
Jun 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds handling for fatal crashes of any type. Just so you don't have to see a giant error stack on your console.

The feature is turned on by the
--no-panicoption or by the environment variable NODE_HTTP_SERVER_NO_PANIC.The output is something like:
Relevant issues
Refers partly to #665
What needs to be done:
Contributor checklist
--helpoutputmasterbranchMaintainer checklist