fix(tokenization): re-raise ImportError to allow RuntimeError/OSError fallback (#45459)#45460
Closed
cloudyun888 wants to merge 1 commit intohuggingface:mainfrom
Closed
Conversation
… fallback When protobuf is not installed, raises ImportError before the try-block exception reaches the except-expression, causing the RuntimeError and OSError handlers below to never execute. Fix: catch ImportError directly and re-raise so downstream handlers run. Fixes huggingface#45459
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When protobuf is not installed, is a function call used as an expression. Because it is evaluated lazily when the try block raises, the resulting from the function itself bypasses the RuntimeError and OSError handlers below it, silently swallowing the original exception.
Changes
Testing
Fixes #45459