Open
Conversation
|
This isn't actually an issue in JavaScript, since array indexes are 32-bit integers and numbers are double-precision floating point numbers (with 53 bits of precision). Any It still might be worth changing for teaching purposes since it is a bug in C/C++/Java/etc. |
Collaborator
|
If you add a comment above it explaining why you're doing it this way, I'll merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If stopIndex+startIndex is greater than the greatest integer allowed by the language, then (stopIndex + startIndex) will overflow.
One way to fix this is to rewrite the average as:
(stopIndex + startIndex)/2 == startIndex + (stopIndex - startIndex)/2
startIndex + (stopIndex - startIndex)/2 never overflows, as it is always strictly less than stopIndex and so is any intermediate result of the computation.