fix(client): cancel idle interval when pool empties - #292
Open
lrowe wants to merge 1 commit into
Open
Conversation
|
This is tied to hyperium/hyper#4100 |
Member
|
Yea, I think this is worth fixing. And it should "just work", a new connection will see |
seanmonstar
requested changes
Aug 17, 2026
seanmonstar
left a comment
seanmonstar
left a comment
Member
There was a problem hiding this comment.
Just needs a test, I think.
lrowe
force-pushed
the
lrowe-cancel-idle-interval-when-empty
branch
from
August 17, 2026 23:30
e82b31f to
42d0315
Compare
lrowe
marked this pull request as ready for review
August 17, 2026 23:31
Author
|
I've added an assert to test_pool_timer_removes_expired that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IdleTask is started on first connection when pool_idle_timeout is set however it is not stopped when the pool is empty leaving the event loop spinning every pool_idle_timeout ms.
I noticed this in Deno (see: denoland/deno#29444) and the fix seems fairly small. Do you think such a change would be worth considering? Happy to work this up with test cases if so.