refactor: drop redundant continue and remove needless_continue allow - #4157
Open
MsfPablo wants to merge 1 commit into
Open
refactor: drop redundant continue and remove needless_continue allow#4157MsfPablo wants to merge 1 commit into
continue and remove needless_continue allow#4157MsfPablo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops three needless
continueexpressions caught by clippy::needless_continue and removes the lint's allow entry from the project lint allowlist, advancing issue #4071.Changes:
elsebranch in dispatch loopPoll::Ready(Some(...))arm in dispatch loopneedless_continue = "allow"Verification:
cargo clippy --features full -- -W clippy::needless_continueis cleancargo build --features fullsucceedscargo test --features full --libpasses (115 passed, 0 failed)Generated with Claude Code; I have read and reviewed every change.