Skip to content

style(lib): Address trivial, low quantity clippy lints. - #4190

Merged
seanmonstar merged 1 commit into
hyperium:masterfrom
Siech0:chore/address-clippy-trivial
Sep 29, 2026
Merged

seanmonstar merged 1 commit into
hyperium:masterfrom
Siech0:chore/address-clippy-trivial

Conversation

@Siech0

@Siech0 Siech0 commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Address trivial, low quantity clippy lint findings, I didn't know if this would be acceptable or not, but each of these lints are very trivial and occur only once each. I'll happily split this PR for you, but I didn't want to overwhelm you with minute pull requests.

Towards #4071

@Siech0
Siech0 force-pushed the chore/address-clippy-trivial branch 3 times, most recently from 5977681 to 1b6624d Compare September 15, 2026 15:06

@dswij dswij left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on rustfmt. Can you help take a look?

@Siech0
Siech0 force-pushed the chore/address-clippy-trivial branch 3 times, most recently from 023f321 to 07f2829 Compare September 16, 2026 15:28
@Siech0

Siech0 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

CI is failing on rustfmt. Can you help take a look?

I've resolved it. cargo fmt didn't reach the files I thought they would. I also updated the commit history to reflect the repo's commit guidelines, I had accidentally included a period in the commit message.

@Siech0
Siech0 force-pushed the chore/address-clippy-trivial branch from 07f2829 to 59ab06a Compare September 16, 2026 15:46
@Siech0
Siech0 requested a review from dswij September 16, 2026 15:46
@Siech0
Siech0 force-pushed the chore/address-clippy-trivial branch from e1c6cb0 to f1cce99 Compare September 20, 2026 08:01
@seanmonstar

Copy link
Copy Markdown
Member

Apologies, the other PR caused conflicts with this one.

@dswij

dswij commented Sep 29, 2026

Copy link
Copy Markdown
Member

@Siech0 can you help to resolve the conflicts?

@Siech0
Siech0 force-pushed the chore/address-clippy-trivial branch from f1cce99 to 757b5da Compare September 29, 2026 19:40
@Siech0

Siech0 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@Siech0 can you help to resolve the conflicts?

I've updated it, sorry the delay.

@seanmonstar
seanmonstar merged commit c954d80 into hyperium:master Sep 29, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants