Skip to content

Fix ARM workflow runner routing - #1814

Merged
simongdavies merged 2 commits into
hyperlight-dev:mainfrom
simongdavies:simongdavies-fix-workflow-runner-routing
Sep 9, 2026
Merged

Fix ARM workflow runner routing#1814
simongdavies merged 2 commits into
hyperlight-dev:mainfrom
simongdavies:simongdavies-fix-workflow-runner-routing

Conversation

@simongdavies

@simongdavies simongdavies commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

Removed the ubuntu-24.04 label from ARM jobs in preparation for remvoing the label from the self-hosted runners (the presence of this label caused any job that uses ubuntu-24.04 as a runs-on label to potentially target the ARM runners.

Also fixed a bug where examples were being run on kvm instead of hvf.

  • ARM Linux selectors use the built-in OS and architecture labels, with kvm where required. Guest builds need no hypervisor label.

  • ARM HVF examples run on native macOS runners using the shared metrics and logging recipe.

  • macOS Rust cache cleanup excludes shared Cargo binaries, matching the build-test workflow.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 9, 2026 11:56
@simongdavies simongdavies added area/infrastructure Concerns infrastructure rather than core functionality area/testing Related to tests or testing infrastructure kind/bugfix For PRs that fix bugs ready-for-review PR is ready for (re-)review labels Sep 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new ARM HVF selector uses macos instead of macOS, which can prevent jobs from matching any runner labels and block workflow execution.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates GitHub Actions runner selectors to route ARM jobs using simplified label sets (dropping ubuntu-24.04), and adjusts ARM HVF example execution to target native macOS runners while keeping existing Linux coverage.

Changes:

  • Remove ubuntu-24.04 from multiple ARM self-hosted runs-on label sets (and drop hypervisor label for guest builds).
  • Route ARM example runs based on hypervisor (HVF → macOS, KVM → Linux) and split example execution per OS.
  • Adjust Rust cache behavior to avoid ~/.cargo/bin cleanup/caching issues on macOS runners.
File summaries
File Description
.github/workflows/PrimeCaches.yml Drops ubuntu-24.04 from ARM KVM runner labels for cache priming.
.github/workflows/dep_run_examples.yml Routes ARM runs to macOS for HVF vs Linux for KVM; updates cache-bin and OS-specific example steps.
.github/workflows/dep_fuzzing.yml Drops ubuntu-24.04 from ARM KVM runner labels for fuzzing.
.github/workflows/dep_build_guests.yml Drops ubuntu-24.04 and hypervisor label from ARM guest build runner labels.
.github/workflows/dep_benchmarks.yml Drops ubuntu-24.04 from ARM KVM runner labels for benchmarks.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/dep_run_examples.yml

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Run hyperlight-dev/ci-setup-workflow@2f4142ba17cf573af44fc1e1f1ffc743daded5b3

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

dblnz
dblnz previously approved these changes Sep 9, 2026

@dblnz dblnz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a single question in the comments!

Comment thread .github/workflows/dep_run_examples.yml
Comment thread .github/workflows/dep_run_examples.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@simongdavies
simongdavies merged commit 053b0c8 into hyperlight-dev:main Sep 9, 2026
57 of 62 checks passed
@github-actions github-actions Bot removed the ready-for-review PR is ready for (re-)review label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infrastructure Concerns infrastructure rather than core functionality area/testing Related to tests or testing infrastructure kind/bugfix For PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants