Support multisig userSetAbstraction#299
Open
hl-core-dev wants to merge 2 commits into
Open
Conversation
traderben
reviewed
Jun 4, 2026
| # b is the public address of the builder, f is the amount of the fee in tenths of basis points. e.g. 10 means 1 basis point | ||
| BuilderInfo = TypedDict("BuilderInfo", {"b": str, "f": int}) | ||
| Abstraction = Literal["unifiedAccount", "portfolioMargin", "disabled"] | ||
| Abstraction = Literal["default", "dexAbstraction", "unifiedAccount", "portfolioMargin", "disabled"] |
Contributor
There was a problem hiding this comment.
You can't set default and we are in the process of removing support for dexAbstraction, so I don't think it's worth adding these
|
|
||
|
|
||
| def main(): | ||
| _address, info, exchange = example_utils.setup(constants.TESTNET_API_URL, skip_ws=True) |
Contributor
There was a problem hiding this comment.
Is there a reason we don't use address and instead use exchange.wallet.address? I think using address is simpler and matches the other examples
| abstraction = "disabled" | ||
| timestamp = get_timestamp_ms() | ||
|
|
||
| # Use the human abstraction string here. Exchange.multi_sig canonicalizes this action to the wire enum value |
Contributor
There was a problem hiding this comment.
Maybe this should be a bit stronger? E.g. You must use
The way things get parsed and converted it's easy to not realize that some of the signatures need one version and others need a different version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan