Adds Optional typing to Row and Column Indicator Label#373
Open
VictorGaiva wants to merge 2 commits intoiddan:masterfrom
Open
Adds Optional typing to Row and Column Indicator Label#373VictorGaiva wants to merge 2 commits intoiddan:masterfrom
VictorGaiva wants to merge 2 commits intoiddan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows a user pass a row and column labels with types different from
string, which makes RowIndicator or ColumnIndicator components required, with the matching typing signature.You can pass a different type for the label
But you don't pass the component, the typecheck fails
But if the passed labels
extends string, it doesn't fail anymoreMotiviation
While passing a label with types other than 'string', and using a custom RowIndicator component to manually render the content of the label, it was not correctly typechecking.