Repository navigation
Conversation
PR SummaryIntroduced a Table Data Gateway pattern for the CUSTOMERS table, including an immutable Customer record, a demonstration App using an in-memory H2 database, UML diagram, and README. Added a new Maven module with tests to validate CRUD operations and to cover the gateway behavior. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (8)
- pom.xml (1 hunk)
- table-data-gateway/README.md (1 hunk)
- table-data-gateway/etc/table-data-gateway.urm.puml (1 hunk)
- table-data-gateway/pom.xml (1 hunk)
- table-data-gateway/src/main/java/com/iluwatar/tabledatagateway/App.java (1 hunk)
- table-data-gateway/src/main/java/com/iluwatar/tabledatagateway/Customer.java (1 hunk)
- table-data-gateway/src/main/java/com/iluwatar/tabledatagateway/CustomerTableGateway.java (1 hunk)
- table-data-gateway/src/test/java/com/iluwatar/tabledatagateway/CustomerTableGatewayTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
-
table-data-gateway/src/main/java/com/iluwatar/tabledatagateway/CustomerTableGateway.java [42-42]
best_practice: "Declare gateway as final."
-
table-data-gateway/pom.xml [53-57]
best_practice: "Add JUnit Jupiter API dependency."
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3626 +/- ##
============================================
+ Coverage 84.06% 84.11% +0.05%
- Complexity 4353 4368 +15
============================================
Files 1133 1136 +3
Lines 15400 15475 +75
Branches 739 743 +4
============================================
+ Hits 12946 13017 +71
- Misses 2158 2159 +1
- Partials 296 299 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- b4ccfa5: test: improve table data gateway coverage
Files Processed (5)
- pom.xml (2 hunks)
- table-data-gateway/pom.xml (1 hunk)
- table-data-gateway/src/main/java/com/iluwatar/tabledatagateway/CustomerTableGateway.java (1 hunk)
- table-data-gateway/src/test/java/com/iluwatar/tabledatagateway/AppTest.java (1 hunk)
- table-data-gateway/src/test/java/com/iluwatar/tabledatagateway/CustomerTableGatewayTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (4)
-
pom.xml [265-265]
enhancement: "Add table-data-gateway module to the aggregator"
-
pom.xml [327-333]
enhancement: "Add JUnit 5 API dependency in root POM"
-
table-data-gateway/pom.xml [75-75]
enhancement: "Set runnable main class in table-data-gateway module"
-
table-data-gateway/src/main/java/com/iluwatar/tabledatagateway/CustomerTableGateway.java [73-73]
best_practice: "Add null checks for Customer fields in insert"
Summary
Validation
Closes #1318