[BUGFIX] Avoid method calls on null with use of null safe operators#1359
Merged
mschwemer merged 1 commit intoin2code-de:masterfrom Mar 10, 2026
Merged
[BUGFIX] Avoid method calls on null with use of null safe operators#1359mschwemer merged 1 commit intoin2code-de:masterfrom
mschwemer merged 1 commit intoin2code-de:masterfrom
Conversation
`FrontendUtility::getCurrentPageIdentifier()` and `FrontendUtility::getSysLanguageUid()` received a guard clause a while ago to prevent calling `getAttribute()` on a null request. While this solves issues with a nullable request, there are still potential issues with calling a method on a null return value of `getAttribute()` The use of null-safe operators resolve this issue and make the guard clauses superfluous. Fixes: in2code-de#1358
mschwemer
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrontendUtility::getCurrentPageIdentifier()andFrontendUtility::getSysLanguageUid()received a guard clause a while ago to prevent callinggetAttribute()on a null request.While this solves issues with a nullable request, there are still potential issues with calling a method on a null return value of
getAttribute()The use of null-safe operators resolve this issue and make the guard clauses superfluous.
Fixes: #1358