Skip to content

fix(cold): drain in-flight reads before executing writes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prestwich merged 1 commit into from
Mar 11, 2026
Merged

fix(cold): drain in-flight reads before executing writes #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/cold/src/task/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,12 @@ impl<B: ColdStorage> ColdStorageTask<B> {
debug!("Cold storage write channel closed");
break;
};
// Drain in-flight reads before executing the write to
// ensure exclusive access to the backend.
self.task_tracker.close();
self.task_tracker.wait().await;
self.task_tracker.reopen();

self.inner.handle_write(req).await;
}

Expand Down