Skip to content

[MBL-19676][S/P/T] Upgrade to Xcode 26.4#3966

Merged
vargaat merged 25 commits intomasterfrom
chore/Xcode-26.4
Apr 15, 2026
Merged

[MBL-19676][S/P/T] Upgrade to Xcode 26.4#3966
vargaat merged 25 commits intomasterfrom
chore/Xcode-26.4

Conversation

@petkybenedek
Copy link
Copy Markdown
Contributor

@petkybenedek petkybenedek commented Mar 27, 2026

refs: MBL-19676
builds: Student, Parent, Teacher
affects: Student, Parent, Teacher
release note: none

Changes

  • weak let: From now, weak var generates a build warning saying that it should be weak let.
  • Default view parameters: An error appeared indicating that that Label's type inference is ambiguous.
  • Bitrise stamps prevented the build. Since they were not working since the new app icons, I removed the step after consulting with @vargaat.
  • Module verifier was recommended for Core and Horizon. It did not cause problems, but according to this article, it may help catching runtime errors.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

refs: MBL-19676
builds: Student, Parent, Teacher
affects: Student, Parent, Teacher
release note: none
refs:
builds:
affects:
release note:

test plan:
Cannot use default expression for inference of '(Text) -> Label' because it is inferrable from parameters #1, #5; this will be an error in a future Swift language mode
@bitrise
Copy link
Copy Markdown
Contributor

bitrise bot commented Mar 27, 2026

Builds

Commit: Horzion TestsFoundation dependency (dbed883)
Build Number: 1791
Built At: Apr 14 12:24 CEST (04/14 04:24 AM MDT)

Student
Teacher
Parent

@bitrise

This comment was marked as outdated.

@bitrise

This comment was marked as outdated.

@bitrise

This comment was marked as outdated.

@bitrise

This comment was marked as outdated.

@bitrise

This comment was marked as outdated.

@petkybenedek petkybenedek self-assigned this Mar 30, 2026
@petkybenedek petkybenedek marked this pull request as ready for review April 8, 2026 08:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

PR Checks

Commit: Horzion TestsFoundation dependency (dbed883)
Built At: Apr 14 10:23 UTC (04/14 04:23 AM MDT)

✅ PR Description
✅ Copyright Headers
✅ SwiftLint
✅ Build CITests
✅ Unit Tests
✅ Code Coverage

suhaibabsi-inst
suhaibabsi-inst previously approved these changes Apr 9, 2026
Copy link
Copy Markdown
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • .github/workflows/pr-checks.yml also need to be updated

@petkybenedek petkybenedek requested a review from vargaat April 9, 2026 13:16
Copy link
Copy Markdown
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + 1

Copy link
Copy Markdown
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could we also get these warnings fixed?
    Image
  • The export translations script also fails since I updated the stack to the new Xcode, please also take a look on that.

@petkybenedek
Copy link
Copy Markdown
Contributor Author

Addressed weak var warnings, throw warning and missing TestsFoundation dependency. Firebase dependency warnings can be solved by updating firebase. Checked on the dependency update PR and it seems to be solved.

Copy link
Copy Markdown
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@vargaat vargaat merged commit 583ec29 into master Apr 15, 2026
5 checks passed
@vargaat vargaat deleted the chore/Xcode-26.4 branch April 15, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants