Repository navigation
Unify concurrent and non-concurrent MultiMutableVamana index - #465
Open
razdoburdin wants to merge 2 commits into
Open
razdoburdin wants to merge 2 commits into
razdoburdin wants to merge 2 commits into
Conversation
razdoburdin
requested review from
ahuber21,
mihaic,
rfsaliev and
yuejiaointel
as code owners
November 4, 2026 10:39
razdoburdin
marked this pull request as draft
November 4, 2026 10:40
razdoburdin
marked this pull request as ready for review
November 4, 2026 15:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up the #439
This PR ports two fixes from concurrent to non-concurrent MultiMutableVamanaIndex.
constexpr bool Conurrent flag is added to
vamana::MultiMutableVamanaIndexandvamana::MultiBatchIterator. The flag is calculated based on graph type. Theconcurrent::MultiMutableVamanaIndexandconcurrent::MultiBatchIteratorare now aliases tovamana::MultiMutableVamanaIndexandvamana::MultiBatchIteratorSo
vamana::MultiMutableVamanaIndexandvamana::MultiBatchIteratorclasses cover both cases. The constexpr bool Concurrent flag is used to cover differences in logic between concurrent and non-concurrent cases.