llvm-foreach: print full command when failing#22044
Open
crystarm wants to merge 1 commit into
Open
Conversation
Author
|
Hi @sarnex!! (。・ω・。) Could you please take a look when you have a chance? I'm not entirely sure who would be the best person to ping here... But I'm tagging you since you reported the original issue. |
Contributor
|
Maybe @YuriPlyakhin or @maksimsab can take a first look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20747
Summary
llvm-foreachcurrently reports generic errors (for example,No such file or directory) without showing which command failed.This change improves diagnostics by printing the full command line that
llvm-foreachattempted to run.What changed
sys::printArg(...)to preserve proper quoting.findProgramByName),ExecuteNoWaitwithExecutionFailed),Tests
Extended
llvm-foreachtests on both platforms:llvm/test/tools/llvm-foreach/llvm-foreach-lin.llllvm/test/tools/llvm-foreach/llvm-foreach-win.llAdded checks for:
false/cmd /c exit 1),llvm-foreach-command-does-not-exist),llvm-foreach: command: ...output.Validation
llvm-litrun forllvm/test/tools/llvm-foreachin local Linux setup (Linux tests pass; Windows-specific test is unsupported as expected).