[SYCL][TEST]Fix half normalize tolerance in marray_geometric#22516
Open
vishwajithupendra wants to merge 1 commit into
Open
[SYCL][TEST]Fix half normalize tolerance in marray_geometric#22516vishwajithupendra wants to merge 1 commit into
vishwajithupendra wants to merge 1 commit into
Conversation
Use 1e-3 absolute delta for all half normalize calls, consistent with other half geometric tests (length, distance). The normalize operation chains three half-precision rounding steps (dot product -> rsqrt -> per-component multiply), each introducing up to 1 ULP of error. At the output values (~0.18 to ~0.89), 1 ULP in half precision is already in the range ~1.7e-4 to ~6.6e-4, so tolerances of 1e-4 or tighter are too close to or below 1 ULP and risk false failures. 1e-3 is the minimum round tolerance that sits comfortably above the 1 ULP range at these values and covers the rounding differences observed on Adreno GPU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use 1e-3 absolute delta for all half normalize calls, consistent with other half geometric tests (length, distance).
The normalize operation chains three half-precision rounding steps (dot product -> rsqrt -> per-component multiply), each introducing up to 1 ULP of error. At the output values (~0.18 to ~0.89), 1 ULP in half precision is already in the range ~1.7e-4 to ~6.6e-4, so tolerances of 1e-4 or tighter are too close to or below 1 ULP and risk false failures. 1e-3 is the minimum round tolerance that sits comfortably above the 1 ULP range at these values and covers the rounding differences observed on Adreno GPU.