[SYCL][FE] Make llvm.fpbuiltin.sincos to accept anyptr parameter#22517
[SYCL][FE] Make llvm.fpbuiltin.sincos to accept anyptr parameter#22517jinge90 wants to merge 38 commits into
Conversation
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
|
Hi, @zahiraam |
|
Hi, @intel/dpcpp-cfe-reviewers @intel/dpcpp-tools-reviewers @intel/llvm-reviewers-runtime |
YuriPlyakhin
left a comment
There was a problem hiding this comment.
the change in llvm/include/llvm/IR/Intrinsics.td LGTM
Question for my education: why do we have this divergence from upstream (I mean the entire Floating Point Builtin Intrinsics block?
The entire |
llvm.fpbuiltin.sincos intrinsic accepts llvm_ptr_type parameter which means it only expects pointer parameter with AS0, this will lead to compiler crash in SYCL device compilation. This PR fixes the compiler crash issue by making it to accept llvm_anyptr_type parameter, the newly added sincos_fpbuiltin_device.cpp test will lead to compiler crash without this fix.