Skip to content

[SYCL] Deprecate legacy info::platform::profile descriptor#22519

Merged
dm-vodopyanov merged 3 commits into
intel:syclfrom
crystarm:deprecate-platform-info-profile
Jul 6, 2026
Merged

[SYCL] Deprecate legacy info::platform::profile descriptor#22519
dm-vodopyanov merged 3 commits into
intel:syclfrom
crystarm:deprecate-platform-info-profile

Conversation

@crystarm

@crystarm crystarm commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #22506.

Summary

info::platform::profile is a legacy SYCL 1.2.1 descriptor that has no equivalent in SYCL 2020. This PR deprecates it and schedules it for removal in the next ABI-break window, following the existing pattern used for info::device::atomic64.

Changes

  • sycl/include/sycl/info/platform.hpp: wrap info::platform::profile in #ifndef __INTEL_PREVIEW_BREAKING_CHANGES and mark it with __SYCL_DEPRECATED so users get a compiler warning.
  • sycl/test-e2e/Basic/info.cpp: guard the profile query with the same macro so the test compiles in both modes.

Behaviour

Macro defined? Effect
__INTEL_PREVIEW_BREAKING_CHANGES not defined profile available, emits deprecation warning
__INTEL_PREVIEW_BREAKING_CHANGES defined profile removed entirely

@crystarm crystarm requested a review from a team as a code owner July 2, 2026 11:06
@crystarm crystarm requested a review from sergey-semenov July 2, 2026 11:06
@crystarm crystarm marked this pull request as draft July 2, 2026 11:57
@KornevNikita

Copy link
Copy Markdown
Contributor

@crystarm you have an access to the pre-commit logs, right?

@crystarm crystarm force-pushed the deprecate-platform-info-profile branch from ae156f1 to bd971ee Compare July 2, 2026 12:15
@crystarm

crystarm commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@KornevNikita
Probably not, I have no idea what you're referring to... ( ╹ -╹)

@crystarm crystarm marked this pull request as ready for review July 2, 2026 12:24
@KornevNikita

KornevNikita commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@KornevNikita Probably not, I have no idea what you're referring to... ( ╹ -╹)

I mean - can you see the failures? There was a failure before you force-pushed (I'd suggest to avoid it, the history is more obvious this way).

@crystarm crystarm force-pushed the deprecate-platform-info-profile branch from 925aec5 to b18f8f6 Compare July 2, 2026 12:39
Comment thread sycl/test-e2e/Basic/info.cpp
@KornevNikita

Copy link
Copy Markdown
Contributor

@crystarm please fix the format

@KornevNikita

Copy link
Copy Markdown
Contributor

@sergey-semenov could you review please

@dm-vodopyanov dm-vodopyanov merged commit d84f142 into intel:sycl Jul 6, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove undocumented platform::info desc

4 participants