[SYCL] Deprecate legacy info::kernel descriptors#22520
Open
crystarm wants to merge 2 commits into
Open
Conversation
| struct function_name : kernel_traits<UR_KERNEL_INFO_FUNCTION_NAME> { | ||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| struct __SYCL_DEPRECATED( | ||
| "info::kernel::function_name is a legacy descriptor not part of SYCL " |
Contributor
There was a problem hiding this comment.
I doubt we should explain that it is a legacy descriptor here. usually we just say that something is deprecated.
@dm-vodopyanov can you please guide us here?
crystarm
force-pushed
the
deprecate-legacy-kernel-info-descriptors
branch
from
d6e8473 to
7af6a9c
Compare
KornevNikita
reviewed
Jul 2, 2026
KornevNikita
reviewed
Jul 6, 2026
|
|
||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| #include <sycl/detail/defines_elementary.hpp> // for __SYCL_DEPRECATED | ||
| #endif |
Contributor
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif // __INTEL_PREVIEW_BREAKING_CHANGES |
Contributor
|
@crystarm could you please resolve format & pre-commit issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22505.
Deprecate three undocumented legacy
info::kerneldescriptors that are not part of SYCL 2020:info::kernel::function_nameinfo::kernel::reference_countinfo::kernel::contextEach descriptor is now annotated with
__SYCL_DEPRECATED(...)and guarded by#ifndef __INTEL_PREVIEW_BREAKING_CHANGES, following the same pattern asinfo::platform::profileandinfo::device::atomic64.