Remove undocumented descriptors#22542
Conversation
|
@KornevNikita can I get a review on this PR? Thanks! I found some more non-standard descriptors for which I am going to open issues Update: I think I misunderstood the scope of the original issue, I missed that this issue should have covered only |
KornevNikita
left a comment
KornevNikita
left a comment
There was a problem hiding this comment.
Just a quick Sunday review, will take an additional one tomorrow.
| struct reference_count : context_traits<UR_CONTEXT_INFO_REFERENCE_COUNT> { | ||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| struct __SYCL_DEPRECATED( | ||
| "reference_count is non-standard and will be removed in next major release") |
| @@ -461,7 +472,7 @@ struct ext_oneapi_srgb : device_traits<UR_DEVICE_INFO_IMAGE_SRGB> { | |||
| }; | |||
|
|
|||
| // Deprecated oneapi/intel extension | |||
There was a problem hiding this comment.
Let's insert the macro above this comment
| // Deprecated oneapi/intel extension | |
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | |
| // Deprecated oneapi/intel extension |
| return false; | ||
| } | ||
|
|
||
| CASE(info::device::usm_device_allocations) { |
There was a problem hiding this comment.
I think we should keep this and below under macro
let's stick to device info descriptors, other classes are covered by different PRs |
| }; | ||
| struct usm_restricted_shared_allocations | ||
| struct __SYCL_DEPRECATED( | ||
| "use sycl::aspect::usm_restricted_shared_allocations instead") |
There was a problem hiding this comment.
There is no such aspect
| }; | ||
| #endif // __INTEL_PREVIEW_BREAKING_CHANGES | ||
| // Extensions | ||
| struct sub_group_independent_forward_progress |
There was a problem hiding this comment.
Just noticed - we need to deprecate this as well since the extension has been deprecated - https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/deprecated/sycl_ext_oneapi_sub_group.asciidoc
|
Ok.. I think this PR is getting close to final touches if not already. I am experiencing some issues with the target But I remember being able to run it, I used the builbot scripts to configure, compile and check the build, I also re-ran |
2 participants
Removal of non-standard descriptors from multiple classes
fixes #22477